Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package releases #1249

Merged
merged 7 commits into from
Mar 8, 2024
Merged

New package releases #1249

merged 7 commits into from
Mar 8, 2024

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Mar 7, 2024

Leaving this as a draft until I'm a bit more confident we're ready to pull the trigger here.

Nothing too noteworthy in this PR, just the usual dependency updates and what not. I've also moved esp-hal's CHANGELOG.md into the esp-hal directory, where it probably belongs. Can revert this change if anybody feels it's the wrong move.

For esp-hal, I've added the documentation key to the Cargo manifest, but we will need to confirm the URL before publishing.

As usual, if anything looks off or if I'm missing anything, please let me know!

Closes #446

@jessebraham jessebraham mentioned this pull request Mar 7, 2024
5 tasks
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 7, 2024

I've also moved esp-hal's CHANGELOG.md into the esp-hal directory, where it probably belongs. Can revert this change if anybody feels it's the wrong move.

I agree with that

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the amazing work done to achieve this!

esp-hal/Cargo.toml Outdated Show resolved Hide resolved
esp-hal/Cargo.toml Outdated Show resolved Hide resolved
@jessebraham jessebraham marked this pull request as ready for review March 8, 2024 12:50
@jessebraham
Copy link
Member Author

cc @MabezDev

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one link that needs fixing up and this is ready to go!

esp-hal/README.md Outdated Show resolved Hide resolved
@jessebraham jessebraham added this pull request to the merge queue Mar 8, 2024
Merged via the queue into esp-rs:main with commit e198f0e Mar 8, 2024
18 checks passed
@jessebraham jessebraham deleted the feature/release branch March 8, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Unify the HAL
4 participants