-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ROM memcpy and friends over compiler-builtins function #1255
Conversation
I thought I was overriding the symbol, not providing but I see the changed symbol here. Whatever 🤷♂️
I think there was something the other way around. For some chips esp-wifi already uses the ROM functions and some crypto (?) driver example in esp-hal broke 🤔 But can't find the issue - not in esp-wifi and not in esp-hal issues |
Found the issue: https://github.com/esp-rs/esp-wifi/issues/245 Hopefully just the driver makes assumptions which we can fix - or maybe it's just working now |
Just double checked: I can make esp-wifi work with this by locally commenting out So, it's definitely not a problem of this PR |
Just double checked: I can make esp-wifi work with this by locally commenting out So it's definitely not a problem of this PR |
I will investigate this problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hopefully the TRNG issues will be resolved tomorrow morning!
nm examples/target/xtensa-esp32s3-none-elf/release/gpio_interrupt | grep memcpy
shows0x400011f4
on esp32s3, so it looks like this is correctly overriding the linkage.@bjoernQ maybe you were using
PROVIDE
which I think only "fills" in the symbol if its missing.I think the last time memcpy from ROM was enabled, bad things with esp-wifi happened, @bjoernQ do you recall this, and would you mind testing?