Remove most PSRAM features #2178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
requested changes
Sep 17, 2024
MabezDev
reviewed
Sep 17, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
f28878a
to
161c546
Compare
|
|
MabezDev
reviewed
Sep 18, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
fde90d5
to
3fe55f6
Compare
Dominaezzz
reviewed
Sep 18, 2024
MabezDev
requested changes
Sep 19, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
03a10f7
to
f1d0a51
Compare
MabezDev
reviewed
Sep 19, 2024
Co-authored-by: Scott Mabin <[email protected]>
MabezDev
reviewed
Sep 19, 2024
| } | ||
|
|
||
| /// Provide exclusive access to the protected data to the given closure | ||
| pub(crate) fn with<R>(&self, f: impl FnOnce(&mut T) -> R) -> R { |
There was a problem hiding this comment.
With this API you can call with inside with and LockState is not reentrant, so we'll get a panic if we do that. I suppose it's an internal API so maybe it's okay to live with this limitation.
There was a problem hiding this comment.
Panicking is kind of the point here, that's what allows the mutable access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This gets rid of most of the PSRAM related features. We still need
psramandoctal-psramhoweverThis also adds auto-detection of PSRAM size (by using the RAM chip id on S2/S3, just probing memory on ESP32 since reading the chip id didn't work as expected)
The user now needs to pass a configuration parameter to psram_initialize - this way they could avoid RAM size auto-detect and configure things like the PSRAM SPI frequency
Testing
Examples still work