Allow configuring the watchdogs in the init config #2180
Conversation
There was a problem hiding this comment.
Mostly looks good to me, and I agree with @bugadani we should find a better place for these configs.
Another thing to think about it how to test this. I don't think there is a way to do something like #[should_reset] in embedded-test, but we should at least test that recreating the peripheral in "user" code and feeding the wdt works (we should also check that when users construct Rtc etc the wdg registers are not reset.
SergioGasquez
force-pushed
the
feat/wd-config
branch
from
30feb87
to
4f9fe2a
Compare
|
ESP32 hil is failing, but not related to this PR |
SergioGasquez
force-pushed
the
feat/wd-config
branch
2 times, most recently
from
892ed5d
to
591f0c3
Compare
SergioGasquez
force-pushed
the
feat/wd-config
branch
from
591f0c3
to
cd0a8a8
Compare
|
I tested the |
| let mut timg1_wd = crate::timer::timg::Wdt::<self::peripherals::TIMG1>::new(); | ||
| timg1_wd.enable(); | ||
| timg1_wd.set_timeout(duration); |
There was a problem hiding this comment.
Does this play nice with
esp-hal/esp-hal/src/timer/timg.rs
Line 251 in 370f541
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Provides a way to configure watchdogs in
esp_hal::init()Testing
Tested different watchdog configurations in one example.