Enable I2S tests on ESP32 and work around first sample issue #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
bjoernQ
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, note that WS starts from low and corresponds to 18 instead of 16 clock pulses. Also note the order or halfwords (we generate 00, 05, 0A, 0F, 14, ... bytes, or 0500, 0F0A, 1914, ... halfwords)
After, notice the 2 clock pulses before WS goes high:
As a comparison, the following capture is from an S3, demonstrating that we're outputting data a) to the same channel and b) we output channels in the flipped order.