Rework locks #2197
Open
Rework locks #2197
+243
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
lock
branch
2 times, most recently
from
740fb61
to
ef89ed8
Compare
bugadani
force-pushed
the
lock
branch
2 times, most recently
from
c1abe1b
to
d6af970
Compare
Dominaezzz
reviewed
Sep 19, 2024
|
Fun fact: this PR came 2 days before #797 turned one year old :D |
I expect you to mark this occasion in your calendar for next year too :D |
Dominaezzz
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should prevent multi-core apps spinning in interrupt-free context if the other core is holding the global lock.
It's hardly a stress test, but I've ran the multicore examples on an ESP32 and they worked as expected.