Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public hidden I2C APIs #2474

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove public hidden I2C APIs #2474

merged 1 commit into from
Nov 8, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 7, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Part 1 of #2437

@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 7, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the naming of this Info struct and info method to be honest, feels a bit strange reading the driver code in some places. However, I see this is already present in some other drivers, so I will just accept it for what it is. 😁

Otherwise, changes LGTM.

@jessebraham jessebraham added this pull request to the merge queue Nov 8, 2024
@bugadani
Copy link
Contributor Author

bugadani commented Nov 8, 2024

Noted and you're not alone with that opinion. I'm still pointing at embassy for the inspiration but I'm open to change it, although the names are accurate enough in what they represent.

Merged via the queue into esp-rs:main with commit ac4679a Nov 8, 2024
28 checks passed
@bugadani bugadani deleted the i2c-redo branch November 8, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants