Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LpUart::new() set tx_idle_num to 0 twice #2860

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −4
Draft

fix: LpUart::new() set tx_idle_num to 0 twice #2860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a284a4e
fix: LpUart::new() set `tx_idle_num` to 0 twice
zpg6 Dec 21, 2024
6449364
docs: add CHANGELOG entry
zpg6 Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `spi::master::Spi::{into_async, into_blocking}` are now correctly available on the typed driver, to. (#2674)
- It is no longer possible to safely conjure `GpioPin` instances (#2688)
- UART: Public API follows `C-WORD_ORDER` Rust API standard (`VerbObject` order) (#2851)
- `LpUart::new()` was setting `tx_idle_num` to 0 twice (#2860)

### Removed

Expand Down
5 changes: 1 addition & 4 deletions esp-hal/src/uart.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,10 +2077,7 @@ pub mod lp_uart {
w.bit_num().bits(0x3);
w.stop_bit_num().bits(0x1)
});
// Set tx idle
me.uart
.idle_conf()
.modify(|_, w| unsafe { w.tx_idle_num().bits(0) });

// Disable hw-flow control
me.uart
.hwfc_conf()
Expand Down
Loading