You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.
Footnotes
take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below ↩
The reason will be displayed to describe this comment to others. Learn more.
@Urgau Thanks for the information! The above was more or less a stopgap solution till we find the time to fix it in our build-scripts. Since our target is nightly only we always living on the etch, and sometimes this massive lints can throw a wrench into the daily work with not to much benefit. Technically its a nice lint, though most our configs come from outside of rust and are not existing for every compilation run upstream, have to come back later how it pens out directly.
8d0c991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up, @ivmarkov, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare
--check-cfg
args directly inside the[lints]
table with[lints.rust.unexpected_cfgs.check-cfg]
1:Cargo.toml
:Footnotes
take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below ↩
8d0c991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Urgau Thanks for the information! The above was more or less a stopgap solution till we find the time to fix it in our build-scripts. Since our target is nightly only we always living on the etch, and sometimes this massive lints can throw a wrench into the daily work with not to much benefit. Technically its a nice lint, though most our configs come from outside of rust and are not existing for every compilation run upstream, have to come back later how it pens out directly.