LwipIntfDev - config static IP auto gw,mask,dns as in Arduino libraries #9040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so one more, This one is for 'modern' Ethernet libraries W5100lwIP, W5500lwIP and ENC28J60lwIP used without EthernetCompat.
I wrote a test for what I consider a modern Ethernet library (one with config for static IP as in WiFi libraries) and to my surprise these libraries matched my idea. Only the automatic dns, gw, subnet values were not supported here again.
So here is the third PR for auto gw,mask,dns as in Arduino libraries. First was in 'begin' for EthernetCompat, second was
config
with two parameters in WiFiSTA.I had to move the clearing of localIP to
EthernetCompat.end
, because in library withconfig
,disconnect
/end
should not clear static IP settings. (config(INADDR_NONE) should))