Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uriglob to catch all android captive portal requests #9041

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Nov 29, 2023

i observed that i get lots of /generate_204_<uuid> requests when building the captive portal and connecting with an android phone. since #6696, the web server supports uri globs (and other features) to match requests. with the glob we can also redirect the requests with the uuid suffix.

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 1, 2023

Can you please update the comment with your findings with something like
// handles "/generate_204_<uuid>"-like requests when using android

edit
comments must be aligned or you can instead run tests/restyle.sh

@dbu
Copy link
Contributor Author

dbu commented Dec 3, 2023

good point. i adjusted the comment (and hopefully fixed the build error by aligning the doc comments)

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 3, 2023

CI wants an additional space (or you can run it yourself and commit its changes, see above)

@dbu
Copy link
Contributor Author

dbu commented Dec 4, 2023

sorry, first time contributing to a C/C++ project, code styles are different than what i am used to 🙈

now i ran the shell script and pushed the changes. i hope its correct now.

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 4, 2023

Thanks !

@d-a-v d-a-v merged commit 089fe8f into esp8266:master Dec 4, 2023
28 checks passed
@dbu
Copy link
Contributor Author

dbu commented Dec 4, 2023

thank you a lot for maintaining this awesome library!

hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants