Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi config(): warning for legacy idioms #9050

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Dec 8, 2023

@d-a-v
Copy link
Collaborator Author

d-a-v commented Dec 9, 2023

Wording is updated. What do you think ?

@JAndrassy
Copy link
Contributor

I want to add that long before Arduino I always did setup my networks this way so I like the Arduino defaults and I always use config(ip) if I use static IP in a sketch.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Dec 11, 2023

I want to add that long before Arduino I always did setup my networks this way so I like the Arduino defaults and I always use config(ip) if I use static IP in a sketch.

So you're going to see more logs during compilation on esp8266.

It it OK for both of you @JAndrassy @TD-er ?

@TD-er
Copy link
Contributor

TD-er commented Dec 11, 2023

Yep looks OK to me.

@d-a-v d-a-v merged commit d5eb265 into esp8266:master Dec 11, 2023
28 checks passed
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants