Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate TZ.h from zoneinfo #9084

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Generate TZ.h from zoneinfo #9084

merged 6 commits into from
Feb 11, 2024

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Feb 5, 2024

Using tzdata pypi package that ships zoneinfo blobs
Can't use raw data package from IANA, need it built first
Minor tweaks to Espurna script that generated .md

More data than the original, not limited to ZONE/...
Zoneinfo source can be overwritten using path args, if needed
(but, probably not needed, since it would always be preferable to pull the latest version)

Also, allow to override certain names and tz strings independent
of tzdata values (resolves #9007)

@d-a-v
Copy link
Collaborator

d-a-v commented Feb 11, 2024

Convenience proposal:

Ubuntu 22.04 has python 3.10 by default, datetime.UTC is an alias introduced with python 3.11

--- a/tools/format_tzdata.py
+++ b/tools/format_tzdata.py
@@ -123,7 +123,7 @@ def markdown(zones):
 
 def header(zones):
     print(f"// ! ! ! DO NOT EDIT, AUTOMATICALLY GENERATED ! ! !")
-    print(f"// File created {datetime.datetime.now(tz=datetime.UTC)}")
+    print(f"// File created {datetime.datetime.now(tz=datetime.timezone.utc)}")
     print(f"// Based on IANA database {tzdata.IANA_VERSION}")
     print(f"// Re-run <esp8266 arduino core>/tools/{sys.argv[0]} to update")
     print()

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving !

... after TZUpdate.sh is removed.

This change is much better for

  • aliases
  • removing dependency from the other external repo

Using tzdata pypi package that ships zoneinfo blobs
Can't use raw data package from IANA, need it built first
Minor tweaks to Espurna script that generated .md

More data than the original, not limited to ZONE/...
Zoneinfo source can be overwritten using path args, if needed
(but, probably not needed, since it would always be preferable to pull the latest version)

Also, allow to override certain names and tz strings independent
of tzdata values (resolves esp8266#9007)
@d-a-v d-a-v merged commit c96dc26 into esp8266:master Feb 11, 2024
28 checks passed
@mcspr mcspr deleted the tzscript branch February 11, 2024 17:52
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
* Generate TZ.h from zoneinfo

Using tzdata pypi package that ships zoneinfo blobs
Can't use raw data package from IANA, need it built first
Minor tweaks to Espurna script that generated .md

More data than the original, not limited to ZONE/...
Zoneinfo source can be overwritten using path args, if needed
(but, probably not needed, since it would always be preferable to pull the latest version)

Also, allow to override certain names and tz strings independent
of tzdata values (resolves esp8266#9007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants