-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate TZ.h from zoneinfo #9084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convenience proposal: Ubuntu 22.04 has python 3.10 by default, --- a/tools/format_tzdata.py
+++ b/tools/format_tzdata.py
@@ -123,7 +123,7 @@ def markdown(zones):
def header(zones):
print(f"// ! ! ! DO NOT EDIT, AUTOMATICALLY GENERATED ! ! !")
- print(f"// File created {datetime.datetime.now(tz=datetime.UTC)}")
+ print(f"// File created {datetime.datetime.now(tz=datetime.timezone.utc)}")
print(f"// Based on IANA database {tzdata.IANA_VERSION}")
print(f"// Re-run <esp8266 arduino core>/tools/{sys.argv[0]} to update")
print() |
d-a-v
requested changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving !
... after TZUpdate.sh is removed.
This change is much better for
- aliases
- removing dependency from the other external repo
Using tzdata pypi package that ships zoneinfo blobs Can't use raw data package from IANA, need it built first Minor tweaks to Espurna script that generated .md More data than the original, not limited to ZONE/... Zoneinfo source can be overwritten using path args, if needed (but, probably not needed, since it would always be preferable to pull the latest version) Also, allow to override certain names and tz strings independent of tzdata values (resolves esp8266#9007)
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
* Generate TZ.h from zoneinfo Using tzdata pypi package that ships zoneinfo blobs Can't use raw data package from IANA, need it built first Minor tweaks to Espurna script that generated .md More data than the original, not limited to ZONE/... Zoneinfo source can be overwritten using path args, if needed (but, probably not needed, since it would always be preferable to pull the latest version) Also, allow to override certain names and tz strings independent of tzdata values (resolves esp8266#9007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using tzdata pypi package that ships zoneinfo blobs
Can't use raw data package from IANA, need it built first
Minor tweaks to Espurna script that generated .md
More data than the original, not limited to ZONE/...
Zoneinfo source can be overwritten using path args, if needed
(but, probably not needed, since it would always be preferable to pull the latest version)
Also, allow to override certain names and tz strings independent
of tzdata values (resolves #9007)