Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder.py: allowing to use it live #9108

Merged
merged 7 commits into from
Mar 31, 2024
Merged

decoder.py: allowing to use it live #9108

merged 7 commits into from
Mar 31, 2024

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Mar 24, 2024 •
edited
Loading

Changes:

  • avoid ctx repetition
  • hide "DECODE IT"
  • immediately print stack at closing marker
  • check for executable decoder at startup

live command line example:

    pyserial-miniterm /dev/ttyUSB0 115200 | \
        path/to/esp8266/Arduino/tools/decoder.py \
            --tool addr2line \
            --toolchain-path path/to/esp8266/Arduino/tools/xtensa-lx106-elf/bin
            path/to/build.elf

d-a-v
d-a-v commented Mar 24, 2024
View reviewed changes
tools/decoder.py Outdated Show resolved Hide resolved
@d-a-v d-a-v marked this pull request as draft March 24, 2024 23:25
@d-a-v
Copy link
Collaborator Author

d-a-v commented Mar 24, 2024

#9083 should be merged first

@d-a-v
decoder.py: allowing to use it live
f02e2c7 
- avoid ctx repetition
- hide "DECODE IT"
- immediately print stack at closing marker
- check for executable decoder at startup

live command line example:
    pyserial-miniterm /dev/ttyUSB0 115200 | \
        path/to/esp8266/Arduino/tools/decoder.py \
            --tool addr2line \
            --toolchain-path path/to/esp8266/Arduino/tools/xtensa-lx106-elf/bin
            path/to/build.elf
@d-a-v d-a-v changed the title decoder.py: allowing to use it live, fix in_stack and avoid ctx repetition decoder.py: allowing to use it live Mar 26, 2024
mcspr
mcspr reviewed Mar 27, 2024
View reviewed changes
tools/decoder.py Outdated Show resolved Hide resolved
tools/decoder.py Outdated Show resolved Hide resolved
tools/decoder.py Outdated Show resolved Hide resolved
@d-a-v d-a-v marked this pull request as ready for review March 27, 2024 22:44
mcspr
mcspr reviewed Mar 31, 2024
View reviewed changes
tools/decoder.py Outdated Show resolved Hide resolved
@mcspr mcspr merged commit 685f2c9 into esp8266:master Mar 31, 2024
28 checks passed
@d-a-v d-a-v deleted the livedecoder branch March 31, 2024 18:45
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
@d-a-v @hasenradball
decoder.py: allowing to use it live (esp8266#9108)
837cf6b 
- avoid ctx repetition and hide some useless fw debug lines
- hide "DECODE IT"
- immediately print stack at closing marker
- check for tool executable at startup

live command line example
>  pyserial-miniterm /dev/ttyUSB0 115200 | \
        path/to/esp8266/Arduino/tools/decoder.py \
            --tool addr2line \
            --toolchain-path path/to/esp8266/Arduino/tools/xtensa-lx106-elf/bin \
            path/to/build.elf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcspr mcspr mcspr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @mcspr