Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose support for toggle_action in Cover API #8049

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Jan 8, 2025

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

cover:
  - platform: template
    name: Garage Door
    device_class: garage
    open_action:
      logger.log: open_action called
    close_action:
      logger.log: close_action called
    toggle_action:
      logger.log: toggle_action called

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.70%. Comparing base (4d8b5ed) to head (5e6c119).
Report is 1843 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8049      +/-   ##
==========================================
- Coverage   53.70%   53.70%   -0.01%     
==========================================
  Files          50       50              
  Lines        9408     9840     +432     
  Branches     1654     1361     -293     
==========================================
+ Hits         5053     5285     +232     
- Misses       4056     4227     +171     
- Partials      299      328      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants