Restore support for use wake word switch in m5stack atom echo and port to raspiaudio-muse-luxe
#12
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesserockz
requested changes
Sep 29, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Also please split adding the muse luxe into its own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #11
Before merging, I'd recommend to have some more users test the configurations to make sure everything is working as expected as I have not been able to test the
raspiaudio-muse-luxe.factory.yamland I'm not sure if theimprov_serialandesp32_improvcomponents should be in the factory config or the standard config. I created the config based onm5stack atom echo's factory config.