Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(json): Improve requirement checking #10554

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Nov 1, 2024

Description of Change

Change the requirement check for sketches that use WiFi to require either CONFIG_SOC_WIFI_SUPPORTED=y or CONFIG_ESP_WIFI_REMOTE_ENABLED=y.

Also optimize the requirement checks into a function to avoid code duplication.

Tests scenarios

Locally and CI

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Warnings
⚠️ Please consider squashing your 7 commits (simplifying branch history).

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3e3fb95

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Test Results

 56 files   56 suites   4m 18s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 3e3fb95.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz force-pushed the ci/improve_requirements branch 3 times, most recently from 88819bb to 9f5d44f Compare November 2, 2024 15:57
@lucasssvaz lucasssvaz marked this pull request as ready for review November 2, 2024 16:07
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Nov 4, 2024
@lucasssvaz lucasssvaz force-pushed the ci/improve_requirements branch 3 times, most recently from 6cb636c to 2ad2af6 Compare November 5, 2024 03:20
@lucasssvaz lucasssvaz removed the Status: Review needed Issue or PR is awaiting review label Nov 6, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Nov 6, 2024
@me-no-dev me-no-dev merged commit 9f3010f into espressif:master Nov 6, 2024
55 of 57 checks passed
@lucasssvaz lucasssvaz deleted the ci/improve_requirements branch November 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants