-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(json): Improve requirement checking #10554
ci(json): Improve requirement checking #10554
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 4m 18s ⏱️ Results for commit 3e3fb95. ♻️ This comment has been updated with latest results. |
88819bb
to
9f5d44f
Compare
9f5d44f
to
c082837
Compare
6cb636c
to
2ad2af6
Compare
2ad2af6
to
178f4cb
Compare
Description of Change
Change the requirement check for sketches that use WiFi to require either
CONFIG_SOC_WIFI_SUPPORTED=y
orCONFIG_ESP_WIFI_REMOTE_ENABLED=y
.Also optimize the requirement checks into a function to avoid code duplication.
Tests scenarios
Locally and CI