Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(espcoredump): Allow writing to both flash and UART (IDFGH-12554) #13557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nebkat
Copy link
Contributor

@nebkat nebkat commented Apr 8, 2024

Writing core dump to UART is useful when actively developing in esp monitor and you want to immediately check the output.
Writing to flash is separately useful when a crash might occur when esp monitor is not connected and you want to inspect the crash later.

This PR allows both options to be enabled at the same time.

Copy link

github-actions bot commented Apr 8, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello nebkat, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 91fc98d

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 8, 2024
@github-actions github-actions bot changed the title feat(espcoredump): Allow writing to both flash and UART feat(espcoredump): Allow writing to both flash and UART (IDFGH-12554) Apr 8, 2024
@nebkat nebkat force-pushed the coredump-flash-uart branch 3 times, most recently from f99745d to 085fd31 Compare April 8, 2024 00:35
@nebkat nebkat marked this pull request as ready for review April 8, 2024 00:38
@erhankur
Copy link
Collaborator

erhankur commented Apr 8, 2024

@nebkat Thank you for your contribution. We will evaluate internally and decide whether to use both options at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants