Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document additional errs returned by esp_ota_write (IDFGH-12784) #13764

Closed
wants to merge 1 commit into from
Closed

Document additional errs returned by esp_ota_write (IDFGH-12784) #13764

wants to merge 1 commit into from

Conversation

lucic71
Copy link
Contributor

@lucic71 lucic71 commented May 8, 2024

Otherwise, as in the case of esp_partition_write, we can say: "or one of error codes from lower-level partitions driver".

@CLAassistant
Copy link

CLAassistant commented May 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucic71, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 6a8d3af

@espressif-bot espressif-bot added the Status: Opened Issue is new label May 8, 2024
@github-actions github-actions bot changed the title Document additional errs returned by esp_ota_write Document additional errs returned by esp_ota_write (IDFGH-12784) May 8, 2024
@mahavirj
Copy link
Member

sha=ea407fb82ec75a2e666713607e8892f0ffa91556

@mahavirj mahavirj added the PR-Sync-Merge Pull request sync as merge commit label May 10, 2024
hmalpani
hmalpani suggested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@hmalpani hmalpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lucic71
Thanks for updating the documentation. Just one comment otherwise LGTM. Can you please update the PR?
Thanks!

components/app_update/include/esp_ota_ops.h Outdated Show resolved Hide resolved
@hmalpani
Copy link
Collaborator

Hello @lucic71
Thanks for adding the suggested changes. Can you please squash the commits?

@hmalpani hmalpani closed this May 10, 2024
@hmalpani hmalpani reopened this May 10, 2024
@lucic71
Copy link
Contributor Author

lucic71 commented May 10, 2024 •
edited
Loading

Just did that, @hmalpani.

@lucic71
docs(ota): Document additional errs returned by esp_ota_write
6a8d3af 
Squashed commit of the following:

commit f47a894
Author: Lucian Popescu <[email protected]>
Date:   Fri May 10 10:44:17 2024 +0300

    Update correct codes for esp_ota_write

    Co-authored-by: Harshit Malpani <[email protected]>

commit ea407fb
Author: Lucian Popescu <[email protected]>
Date:   Wed May 8 14:06:37 2024 +0300

    docs(ota): Document additional errs returned by esp_ota_write
@hmalpani hmalpani removed the PR-Sync-Merge Pull request sync as merge commit label May 10, 2024
@hmalpani
Copy link
Collaborator

sha=6a8d3af89b9e2f056a48bb5a5fbee6f4ab9c6021

@hmalpani hmalpani added PR-Sync-Update Pull request sync fetch new changes PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Update Pull request sync fetch new changes labels May 10, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: In Progress Work is in progress labels May 10, 2024
@mahavirj
Copy link
Member

Fixed by 37d9a3c

@mahavirj mahavirj closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmalpani hmalpani hmalpani requested changes

@mahavirj mahavirj mahavirj approved these changes

Assignees

@hmalpani hmalpani

Labels
PR-Sync-Merge Pull request sync as merge commit PR-Sync-Update Pull request sync fetch new changes Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucic71 @CLAassistant @mahavirj @hmalpani @espressif-bot