Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ulp): RVfplib as alternative floating point library for ULP RISC-V and LP Core (IDFGH-12981) #13932

Closed

Conversation

andylinpersonal
Copy link
Contributor

@andylinpersonal andylinpersonal commented Jun 7, 2024

Add RVfplib as alternative soft-fp library, which might roughly reduce the code size by 1~3 KiB if only basic single precision arithmetics are used.
Though licensed under GPLv3 with library exeption, RVfplib has already been embedded into latest Cx, Hx and P4's rom code so it should not be an issue.

Copy link

github-actions bot commented Jun 7, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello andylinpersonal, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 8352b11

@andylinpersonal andylinpersonal changed the title feat(ulp): Support RVfplib as alternative soft-fp library feat(ulp): Support RVfplib as alternative floating point library Jun 7, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 7, 2024
@github-actions github-actions bot changed the title feat(ulp): Support RVfplib as alternative floating point library feat(ulp): Support RVfplib as alternative floating point library (IDFGH-12981) Jun 7, 2024
@andylinpersonal andylinpersonal changed the title feat(ulp): Support RVfplib as alternative floating point library (IDFGH-12981) feat(ulp): RVfplib as alternative floating point library for ULP RISC-V and LP Core (IDFGH-12981) Jun 8, 2024
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Jul 3, 2024
@ESP-Marius
Copy link
Collaborator

@andylinpersonal Thanks for the contribution!

Since this use-case is a bit more niche, I'm not sure we should include it in the ULP component (will be difficult for us to support all custom behavior users want)

How do you think about this compromise:

We could make it possible for users to have more direct control of the ULP build system, e.g. by letting users also provide their own cmakefile. Then use-cases like this could be achieved without IDF modification directly in the user's project.

What do you think? (this would also allow setting -msave-restore from your project)

@andylinpersonal
Copy link
Contributor Author

@ESP-Marius

We could make it possible for users to have more direct control of the ULP build system, e.g. by letting users also provide their own cmakefile. Then use-cases like this could be achieved without IDF modification directly in the user's project.

Yes, a more flexible and less intrusive build system for ULP is what we demand. And it will be useful for the more complex use cases in the following ESP32-P4's LP subsystem.

@ESP-Marius
Copy link
Collaborator

@andylinpersonal We've pushed a feature that should hopefully allow achieving stuff like this much easier for users.

You can see an example [here])https://github.com/espressif/esp-idf/blob/master/examples/system/ulp/lp_core/build_system/main/ulp/CMakeLists.txt)

I think with that we'll consider this ticket closed, feel free to reopen it if you still think RVfplib should be available by default for the lp-core.

Or open a new ticket if you are unhappy/have any requests with regards to the ULP build-system.

@ESP-Marius ESP-Marius closed this Jul 31, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Selected for Development Issue is selected for development labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants