Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ulp): Write pin's output mode to the correct register (IDFGH-13065) #14010

Closed
wants to merge 1 commit into from

Conversation

LonerDan
Copy link
Contributor

@LonerDan LonerDan commented Jun 18, 2024

Fixes register mixup.
According to the ESP32-S3 TRM (pages 515 - 516), the output pin's mode is set in the RTC_GPIO_PINn_REG,
bit RTC_GPIO_PINn_PAD_DRIVER, not the RTC_IO_TOUCH_PADn_REG field RTC_IO_TOUCH_PADn_DRV,
which instead controls the drive output strength.

Fixes register mixup. According to the ESP32-S3 TRM (pages 515-516), the output pin's mode is set in the RTC_GPIO_PINn_REG, bit RTC_GPIO_PINn_PAD_DRIVER not the RTC_IO_TOUCH_PADn_REG field RTC_IO_TOUCH_PADn_DRV, which instead controls the drive output strength.
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jun 18, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(ulp): write output mode to the correct register":
    • probably contains Jira ticket reference (515-516). Please remove Jira tickets from commit messages.
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello LonerDan, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 6169404

@LonerDan LonerDan changed the title fix(ulp): write output mode to the correct register fix(ulp): Write pin's output mode to the correct register Jun 18, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 18, 2024
@github-actions github-actions bot changed the title fix(ulp): Write pin's output mode to the correct register fix(ulp): Write pin's output mode to the correct register (IDFGH-13065) Jun 18, 2024
@SoucheSouche
Copy link
Collaborator

Hi @LonerDan, thanks for the PR. We will be looking into it as soon as possible.

@sudeep-mohanty sudeep-mohanty self-requested a review June 18, 2024 12:23
@sudeep-mohanty
Copy link
Collaborator

Hello @LonerDan,
Indeed, the ULP RISC-V API to set the GPIO output mode writes to the wrong register! Thanks for noticing the bug and for fixing it!
I shall pull in your changes and get it ready for merging. Thanks!

@sudeep-mohanty
Copy link
Collaborator

sha=6169404f1f499ec2d60b9a23013b8101f8d19586

@sudeep-mohanty sudeep-mohanty added the PR-Sync-Merge Pull request sync as merge commit label Jun 18, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Jun 18, 2024
@SoucheSouche SoucheSouche reopened this Sep 4, 2024
@SoucheSouche
Copy link
Collaborator

e5d9d1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants