-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ulp): Write pin's output mode to the correct register (IDFGH-13065) #14010
Conversation
Fixes register mixup. According to the ESP32-S3 TRM (pages 515-516), the output pin's mode is set in the RTC_GPIO_PINn_REG, bit RTC_GPIO_PINn_PAD_DRIVER not the RTC_IO_TOUCH_PADn_REG field RTC_IO_TOUCH_PADn_DRV, which instead controls the drive output strength.
👋 Hello LonerDan, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi @LonerDan, thanks for the PR. We will be looking into it as soon as possible. |
Hello @LonerDan, |
sha=6169404f1f499ec2d60b9a23013b8101f8d19586 |
Fixes register mixup.
According to the ESP32-S3 TRM (pages 515 - 516), the output pin's mode is set in the
RTC_GPIO_PINn_REG
,bit
RTC_GPIO_PINn_PAD_DRIVER
, not theRTC_IO_TOUCH_PADn_REG
fieldRTC_IO_TOUCH_PADn_DRV
,which instead controls the drive output strength.