Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): python3.12 support: remove distutils use (IDFGH-13510) #14402

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Aug 19, 2024

Hi,

In python 3.12, the distutils module was removed from the standard library.
Here are simple ways to avoid it.

ref. https://docs.python.org/3/whatsnew/3.12.html#distutils

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 19, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(tools): python3.12 support":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello nim65s, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 727c6a8

@nim65s nim65s force-pushed the distutils branch 2 times, most recently from 505878d to b507e8c Compare August 19, 2024 17:23
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 19, 2024
@github-actions github-actions bot changed the title python3.12 support: remove distutils use python3.12 support: remove distutils use (IDFGH-13510) Aug 19, 2024
@nim65s nim65s force-pushed the distutils branch 2 times, most recently from d19eb5e to 9b671ba Compare August 20, 2024 01:29
Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nim65s, thank you for your contribution. Please take a look at the failing pre-commit ci. There are some changes requested like reordering imports. You can check how to install these hooks locally in Contributions Guide

tools/mass_mfg/mfg_gen.py Outdated Show resolved Hide resolved
@nim65s nim65s changed the title python3.12 support: remove distutils use (IDFGH-13510) fix(tools): python3.12 support: remove distutils use (IDFGH-13510) Aug 24, 2024
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development Status: In Progress Work is in progress and removed Status: Opened Issue is new Status: Selected for Development Issue is selected for development labels Sep 2, 2024
remove distutils use
@nim65s
Copy link
Contributor Author

nim65s commented Sep 4, 2024

thanks @peterdragun, I think this is better now.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Sep 5, 2024
@espressif-bot espressif-bot merged commit 17fed13 into espressif:master Sep 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants