Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): venv detection use VIRTUAL_ENV environment variable (IDFGH-13545) #14435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Aug 24, 2024

Hi,

Here is a simple fix for #12036
This is required for Nix "venv"-like way.

Copy link

github-actions bot commented Aug 24, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello nim65s, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against c25b563

To fix espressif#12036
This is required for Nix "venv"-like way.
@nim65s nim65s changed the title fix venv detection fix(tools): venv detection use VIRTUAL_ENV environment variable Aug 24, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 24, 2024
@github-actions github-actions bot changed the title fix(tools): venv detection use VIRTUAL_ENV environment variable fix(tools): venv detection use VIRTUAL_ENV environment variable (IDFGH-13545) Aug 24, 2024
@DNedic
Copy link
Collaborator

DNedic commented Aug 26, 2024

Hello @nim65s , thank you for submitting this. It looks like this would fix using nix python derivations, will test.

VIRTUAL_ENV is not a perfect way to detect a virtual environment, as you could still run virtual environments scripts directly, without activating it, and it would not be set, but in this case, that should be irellevant.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Selected for Development Issue is selected for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants