Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: S3: adjust default wait values to the slowclock frequency (IDFGH-13564) #14453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

2opremio
Copy link

The wait values depending on the slowclock should be chosen based on the frequency of the slowclock set.

Addresses part of #14441

@2opremio 2opremio changed the title feat: S3: adjust default wait values to the slowclock frequency fix: S3: adjust default wait values to the slowclock frequency Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello 2opremio, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 44264e4

@2opremio 2opremio force-pushed the s3-adjust-default-wait-to-freq branch 2 times, most recently from fd2c10c to 1a9ab70 Compare August 27, 2024 19:01
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 27, 2024
@github-actions github-actions bot changed the title fix: S3: adjust default wait values to the slowclock frequency fix: S3: adjust default wait values to the slowclock frequency (IDFGH-13564) Aug 27, 2024
@2opremio 2opremio force-pushed the s3-adjust-default-wait-to-freq branch from 1a9ab70 to 8a47d33 Compare August 28, 2024 17:57
The wait values depending on the slowclock should be chosen based
on the frequency of the slowclock set.
@ESP-Marius
Copy link
Collaborator

sha=44264e4466fa9449326e60d4ec669e3748639fb9

@ESP-Marius ESP-Marius added the PR-Sync-Merge Pull request sync as merge commit label Sep 3, 2024
@ESP-Marius
Copy link
Collaborator

Thanks @2opremio, we'll review this one internally

@2opremio
Copy link
Author

2opremio commented Sep 3, 2024

To be fair, since the slow clock can change dynamically it would be even better to define the constants in microseconds and not ticks. This would allow setting the ticks dynamically based on the clock calibration.

The code already does this with the XTAL wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants