-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: S3: adjust default wait values to the slowclock frequency (IDFGH-13564) #14453
base: master
Are you sure you want to change the base?
Conversation
👋 Hello 2opremio, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
fd2c10c
to
1a9ab70
Compare
1a9ab70
to
8a47d33
Compare
The wait values depending on the slowclock should be chosen based on the frequency of the slowclock set.
8a47d33
to
44264e4
Compare
sha=44264e4466fa9449326e60d4ec669e3748639fb9 |
Thanks @2opremio, we'll review this one internally |
To be fair, since the slow clock can change dynamically it would be even better to define the constants in microseconds and not ticks. This would allow setting the ticks dynamically based on the clock calibration. The code already does this with the XTAL wait. |
The wait values depending on the slowclock should be chosen based on the frequency of the slowclock set.
Addresses part of #14441