-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp_tinyuf2: fix nvs hidden key (AEGHB-961) #462
base: master
Are you sure you want to change the base?
Conversation
|
👋 Hello wormyrocks, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@wormyrocks LGTM! |
@@ -118,7 +118,7 @@ void esp_restart_from_tinyuf2(void); | |||
* @return | |||
* - ESP_OK: Operation was successful. | |||
*/ | |||
esp_err_t esp_tinyuf2_set_all_key_hidden(bool if_hidden) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wormyrocks, is there any difference? Whether there is a formal parameter or not, makes no difference to the function itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine it won't compile without this change - something to do with the compiler settings in tinyuf2.
Outside of the include guards, all the other declarations in that file follow the same style.
@wormyrocks thanks for your contribution, It looks great to me! |
Description
Allows the use of hidden NVS keys in the uf2 config.ini.
Also fixes an error where NVS entries intended to be hidden would be shown, and entries intended to be shown would be hidden.