Fix: Pass Build env PATH to CMake build #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure PATH from the CDT>Build>ENV>PATH is honored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure PATH from the
Preferences > C/C++ > Build > Environment > PATHis honored while compiling a project.What was happening earlier?
Eclipse uses the CMake command to build a project and this is run through Java process runner. By default, the PATH environment for the Java process is system PATH. If there are multiple python environments found in the system there was an issue during the compilation stage especially while running on Apple M1 systems due to different python architectures
What will happen with PR changes?
This will make sure Java CMake build process is run through
C/C++ > Build > EnvironmentPATHvariable. PATH in preference build environment always configured from the the idf.py export command and it has correctpython_envbased on the idf version and system architecture