-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated nghttp2 component (IEC-132) #348
Merged
mahavirj
merged 2 commits into
espressif:master
from
hrushikesh430:update_component_nghttp2
Jul 8, 2024
Merged
updated nghttp2 component (IEC-132) #348
mahavirj
merged 2 commits into
espressif:master
from
hrushikesh430:update_component_nghttp2
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
updated nghttp2 component
updated nghttp2 component (IEC-132)
Jul 2, 2024
@hrushikesh430 can you add more information about the changelog or maybe the link to the changelog ? |
hrushikesh430
force-pushed
the
update_component_nghttp2
branch
from
July 4, 2024 06:33
5388d61
to
47f33ea
Compare
hrushikesh430
force-pushed
the
update_component_nghttp2
branch
from
July 4, 2024 08:09
d0716ab
to
d48f843
Compare
hrushikesh430
force-pushed
the
update_component_nghttp2
branch
from
July 4, 2024 08:27
d48f843
to
c284174
Compare
mahavirj
approved these changes
Jul 4, 2024
AdityaHPatwardhan
approved these changes
Jul 5, 2024
hmalpani
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the nghttp2 submodule from v1.58.0 or v1.62.1.
Testing -
Tested this component using the example which is in sh2lib component. Checked whether this example runs before and after upgrading the nghttp2
Binary size (http2_request.bin) -
Before - 1015120 Bytes
After - 1015536 Bytes
Library Size (libnghttp.a) -
Before - 82712 Bytes
After - 83087 Bytes
Link to changelog -
https://github.com/nghttp2/nghttp2/releases/tag/v1.62.1