Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIDs for Waveshare ESP32-S3-Touch-AMOLED-1.8 #192

Closed
wants to merge 0 commits into from

Conversation

Y1hsiaochunnn
Copy link
Contributor

Add PIDs for Waveshare ESP32-S3-Touch-AMOLED-1.8 board to be added to CircuitPython, arduino-esp32 and PlatformIO.

Product wiki: The wiki is not yet ready for release

@Y1hsiaochunnn
Copy link
Contributor Author

Hi @Spritetm ,
plz mention me if needs to change the PIDs allocation

@Spritetm
Copy link
Member

Spritetm commented Oct 7, 2024

Hi! Is this PR related to #191 ? Both add seemingly unreleased Waveshare boards.

@Y1hsiaochunnn
Copy link
Contributor Author

1.85 and 1.8 are two different boards

@Spritetm
Copy link
Member

Spritetm commented Oct 8, 2024

That I understand. What I'm wondering is why two seemingly unrelated people post about unreleased Waveshare boards at the same time. Do you both work for Waveshare or something?

@Y1hsiaochunnn
Copy link
Contributor Author

I have seen relevant PR. At present, other colleagues should be sorting out our product integration. I am only responsible for my own board. If there is any question, I will communicate with him after his vacation

@Spritetm
Copy link
Member

Spritetm commented Oct 8, 2024

Clear. I just approved an unrelated board; if you update this merge request, I will merge. Furthermore, I would appreciate it if next time, you make it clear you're a Waveshare employee.

(On a separate note: We're not really happy with a company requesting loads of PIDs, especially for unreleased boards; that is not something that you did in this PR, but you may want to communicate to your manager or whoever is responsible for it that if they want to build loads of variations of boards that use USB, they probably will be better off buying their own USB VID)

@Y1hsiaochunnn
Copy link
Contributor Author

I see what you mean. I will embark on the task,As for this pr, I will close it first, and I will submit another one later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants