check empty customExtraVars PATH

espressif · Dec 26, 2024 · 800c6bd · 800c6bd
1 parent 6bdf494
commit 800c6bd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -1119,14 +1119,21 @@ export async function appendIdfAndToolsToPath(curWorkspace: vscode.Uri) {
       modifiedEnv[pathNameInEnv];
   }
 
-  const extraPathsArray = customExtraVars[pathNameInEnv].split(path.delimiter);
-  for (let extraPath of extraPathsArray) {
-    if (
-      modifiedEnv[pathNameInEnv] &&
-      !modifiedEnv[pathNameInEnv].includes(extraPath)
-    ) {
-      modifiedEnv[pathNameInEnv] =
-        extraPath + path.delimiter + modifiedEnv[pathNameInEnv];
+  if (
+    customExtraVars[pathNameInEnv] &&
+    customExtraVars[pathNameInEnv].length > 0
+  ) {
+    const extraPathsArray = customExtraVars[pathNameInEnv].split(
+      path.delimiter
+    );
+    for (let extraPath of extraPathsArray) {
+      if (
+        modifiedEnv[pathNameInEnv] &&
+        !modifiedEnv[pathNameInEnv].includes(extraPath)
+      ) {
+        modifiedEnv[pathNameInEnv] =
+          extraPath + path.delimiter + modifiedEnv[pathNameInEnv];
+      }
     }
   }
 

diff --git a/testFiles/testWorkspace/.vscode/settings.json b/testFiles/testWorkspace/.vscode/settings.json
@@ -3,11 +3,11 @@
   "idf.espMdfPath": "/test/esp-mdf",
   "idf.port": "/serialport",
   "idf.openOcdConfigs": [
-      "board/esp32-wrover-kit-3.3v.cfg"
+    "board/esp32-wrover-kit-3.3v.cfg"
   ],
   "idf.gitPath": "/usr/bin/git",
   "files.simpleDialog.enable": true,
   "window.dialogStyle": "custom",
   "idf.notificationMode": "Output",
-  "idf.showOnboardingOnInit": false,
+  "idf.showOnboardingOnInit": false
 }