Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation and Commands naming consistency #1082

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Documentation and Commands naming consistency #1082

merged 10 commits into from
Dec 20, 2023

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented Nov 22, 2023 •
edited
Loading

Description

  • Name consistency for the ESP-IDF commands, notifications and tooltips inside the extension and documentation.
  • Changed the documentation for extension installation related to Pre-Requisites.

Type of change

  • Naming consistency
  • This change requires a documentation update

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Download the artifacts for this pull request:

@radurentea radurentea marked this pull request as ready for review December 4, 2023 13:25
brianignacio5
brianignacio5 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea radurentea merged commit f4e1867 into master Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

@AndriiFilippov AndriiFilippov Awaiting requested review from AndriiFilippov

Assignees

@radurentea radurentea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radurentea @brianignacio5