Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1258] feature/walkthrough #1298

Merged
merged 18 commits into from
Nov 25, 2024
Merged

[VSC-1258] feature/walkthrough #1298

merged 18 commits into from
Nov 25, 2024

Conversation

radurentea
Copy link
Collaborator

Description

Create VS Code Walkthrough for our extension

JIRA: https://jira.espressif.com:8443/browse/VSC-1258

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Steps to test this pull request

  1. Install ESP-IDF VS Code extension
  2. After installation, walkthrough menu should appear (after the firs installation this will set "idf.showOnboardingOnInit": false")
  3. If user uninstalls the extension and installs it again "Walkthrough" menu should not appear, unless in user's settings "idf.showOnboardingOnInit" is set to "true" or not being present)
  4. Walkthrough should be present in the menu walkthrough if user runs the command "Help: Welcome" and the ESP-IDF VS Code extension is installed.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: -
  • OS (Windows,Linux and macOS): Windows

Dependent components impacted by this PR:

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows

@radurentea radurentea self-assigned this Aug 30, 2024
@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Sep 10, 2024
Copy link

github-actions bot commented Sep 25, 2024

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Oct 11, 2024
@github-actions github-actions bot closed this Oct 22, 2024
@radurentea radurentea reopened this Oct 31, 2024
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Nov 5, 2024
@radurentea radurentea marked this pull request as ready for review November 19, 2024 08:22
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small changes

walkthroughs/basic/build-flash-monitor.md Outdated Show resolved Hide resolved
walkthroughs/basic/build-flash-monitor.md Show resolved Hide resolved
@Fabricio-ESP Fabricio-ESP changed the title feature/walkthrough [VSC-1258] feature/walkthrough Nov 21, 2024
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thanks for making those adjustments.

@radurentea radurentea merged commit be86f16 into master Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants