Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Provide CN translation for README.md #1335

Merged
merged 1 commit into from
Nov 22, 2024
Merged

docs: Provide CN translation for README.md #1335

merged 1 commit into from
Nov 22, 2024

Conversation

Shen765
Copy link
Collaborator

@Shen765 Shen765 commented Nov 5, 2024

Description

This PR:

  • Adjusted some format issues and unclear expressions in README.md based on Espressif Style Guide
  • Provided CN translation for README.md
  • TODO: Closes DOC-9140 once merged

@Shen765 Shen765 self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

brianignacio5
brianignacio5 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Nov 5, 2024
@brianignacio5 brianignacio5 added the documentation 📝 Solely about the documentation of the project. label Nov 5, 2024
zztiger123
zztiger123 reviewed Nov 7, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
zztiger123
zztiger123 reviewed Nov 7, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
zztiger123
zztiger123 reviewed Nov 7, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
zztiger123
zztiger123 reviewed Nov 7, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
April-Yjj
April-Yjj reviewed Nov 7, 2024
View reviewed changes
Copy link

@April-Yjj April-Yjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shen765, Thanks for translating and revising this long file. Left a few comments, PTAL

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
zztiger123
zztiger123 reviewed Nov 8, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
@Shen765 Shen765 force-pushed the docs/translate_cn_readme branch 2 times, most recently from 7862bbf to 630458e Compare November 14, 2024 03:39
@Shen765
Copy link
Collaborator Author

Shen765 commented Nov 14, 2024

Hi @zztiger123 @April-Yjj Thanks for reviewing. I have re-edited the two files based on your suggestions. Additionally, I translated all commands and menu options into Chinese where available. Plz help review, thx!

@Shen765 Shen765 mentioned this pull request Nov 18, 2024
Merged
Fabricio-ESP
Fabricio-ESP reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor details that can be changed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
April-Yjj
April-Yjj approved these changes Nov 18, 2024
View reviewed changes
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
@Shen765 Shen765 force-pushed the docs/translate_cn_readme branch from 630458e to bd9d71d Compare November 21, 2024 02:59
@Shen765 Shen765 force-pushed the docs/translate_cn_readme branch from bd9d71d to 7ee602d Compare November 22, 2024 03:39
@Shen765 Shen765 merged commit 0dce8ee into master Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricio-ESP Fabricio-ESP Fabricio-ESP approved these changes

@April-Yjj April-Yjj April-Yjj approved these changes

@zztiger123 zztiger123 zztiger123 approved these changes

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees

@Shen765 Shen765

Labels
documentation 📝 Solely about the documentation of the project.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Shen765 @brianignacio5 @zztiger123 @April-Yjj @Fabricio-ESP