-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1515] fix unit tests not being refresh #1338
Conversation
Download the artifacts for this pull request: |
LGTM |
Hi @brianignacio5 , Also noticed that if I rename a test file and try to update the testing tab I see a new entry with the new file name, fur the application does not remove the old entry, so it ends up showing 2 files with the old and new name. If I restart VSCode than it removes the old entry. Is there a reason we would like to keep the old filename on the testing tab? |
Yes that is correct that is looking for test_* files.
Updated the PR to delete all items before creating them on refresh. PTAL again @Fabricio-ESP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working as expected.
Testing tab was able to locate test files and update the list upon clicking the refresh button.
Note that test files should start with test_ and should be inside a folder called test.
This is not properly set int he unit_test example provided by IDF and might confuse the users.
Description
Fix unit tests not being refreshed when Refresh tests button is clicked.
Fixes #1336
Type of change
Steps to test this pull request
Expected behaviour:
Test cases should be added, deleted or modified when Refresh Tests button is executed and test cases have changed.
Expected output:
How has this been tested?
Manual testing using the unity-test esp-idf example.
Test Configuration:
Checklist