Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the Existing IDF Extension Related Commands #1347

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Shen765
Copy link
Collaborator

@Shen765 Shen765 commented Nov 25, 2024

Description

This PR:

  • Reviewed the existing IDF extension related commands (EN/CN version)
  • TODO: Closes DOC-9534 once merged

Copy link

github-actions bot commented Nov 25, 2024

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link

@April-Yjj April-Yjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shen765 , Thank you for translating! I left some comments for 1 of the 3 docs so far, PTAL. We can proceed on the rest 2 files when this one is done.

Feel free to reach out to me for any questions :)

l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
l10n/bundle.l10n.zh-CN.json Outdated Show resolved Hide resolved
@Shen765 Shen765 force-pushed the docs/review_cn_commands branch from 707d92b to 09d7bdb Compare December 3, 2024 03:00
@Shen765
Copy link
Collaborator Author

Shen765 commented Dec 3, 2024

Hi @April-Yjj Left some replies for you. Feel free to proceed with the other two files and edit the EN keys if you feel find any issues. I will revise them as I have done with those in l10n/bundle.l10n.zh-CN.json. :)

@Shen765 Shen765 force-pushed the docs/review_cn_commands branch from 09d7bdb to cb2b167 Compare December 3, 2024 08:22
@brianignacio5
Copy link
Collaborator

The CI seems to fails due to missing param.hasWalkthroughBeenShown in nls.json file. A rebase to current master could solve this issue but zh-CN.nls.json needs to be updated.

package.nls.json Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.zh-CN.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
@April-Yjj
Copy link

April-Yjj commented Dec 9, 2024

Hi @Shen765 Thanks for your translation! Overall LGTM. I've left a few comments for your consideration too, PTAL.

Plus, feel free to close previous threads with my thumbs-up, and start further discussion with new comments!

@Shen765
Copy link
Collaborator Author

Shen765 commented Dec 12, 2024

@April-Yjj Thanks for your careful review! Left some replies for you. Some of the translations in this MR were not critical, so to maintain consistency with already merged documents in this repo, I skipped several editing suggestions. If you feel like any of them do need revision, pls poke me under the corresponding line. If not, pls resolve the threads and approve this PR. Thanks again~

@April-Yjj
Copy link

Hi @Shen765 Thank you! Approved. After final updates pls help resolve threads.

@Shen765 Shen765 force-pushed the docs/review_cn_commands branch from 01ff4a7 to cb034f6 Compare December 12, 2024 08:39
@Shen765 Shen765 merged commit 066fc02 into master Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants