-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the Existing IDF Extension Related Commands #1347
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shen765 , Thank you for translating! I left some comments for 1 of the 3 docs so far, PTAL. We can proceed on the rest 2 files when this one is done.
Feel free to reach out to me for any questions :)
707d92b
to
09d7bdb
Compare
Hi @April-Yjj Left some replies for you. Feel free to proceed with the other two files and edit the EN keys if you feel find any issues. I will revise them as I have done with those in l10n/bundle.l10n.zh-CN.json. :) |
09d7bdb
to
cb2b167
Compare
The CI seems to fails due to missing |
Hi @Shen765 Thanks for your translation! Overall LGTM. I've left a few comments for your consideration too, PTAL. Plus, feel free to close previous threads with my thumbs-up, and start further discussion with new comments! |
@April-Yjj Thanks for your careful review! Left some replies for you. Some of the translations in this MR were not critical, so to maintain consistency with already merged documents in this repo, I skipped several editing suggestions. If you feel like any of them do need revision, pls poke me under the corresponding line. If not, pls resolve the threads and approve this PR. Thanks again~ |
Hi @Shen765 Thank you! Approved. After final updates pls help resolve threads. |
01ff4a7
to
cb034f6
Compare
Description
This PR: