Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test case regex #1377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brianignacio5
Copy link
Collaborator

Description

Update TEST_CASE regex to support spaces between ( and " such as:

TEST_CASE( "New test i just made" , "[mean][fails]" ) and TEST_CASE("New test d i just made","[mean][fails]")

this happens when clang auto format on test_*.c files.

Fixes #1371

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Open a ESP-IDF projects with unit tests like the unity_test example.
  2. Click on Testing tab in the side panel activity bar. Test should be autodiscovered.
  3. Update test name to include spaces like the ones shown in description. Click refresh button. Test should be still visible.
  4. Observe results.
  • Expected behaviour:
    Test with spaces between ( and " should be shown in Testing tab

How has this been tested?

Manual testing.

Test Configuration:

  • ESP-IDF Version: 5.3.2
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v2.0.0 milestone Dec 20, 2024
@brianignacio5 brianignacio5 self-assigned this Dec 20, 2024
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 modified the milestones: v2.0.0, v1.9.1 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Testing: Parsing of test cases fails for TEST_CASE() formatted with spaces (VSC-1544)
1 participant