Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not duplicate python in path env var #1381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

Description

Update PATH modification function (src/utils.ts appendIdfAndToolsToPath) to avoid python_env duplication in env PATH.

Should fix # error in terminal and using bat scripts on Windows.

Fixes #1369

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Click on "ESP-IDF: Open ESP-IDF Terminal".
  2. Running a bat script such as
idf.py build
idf.py fullclean
idf.py build
idf.py fullclean
  1. Observe results. No errors should be produced.
  • Expected behaviour: No errors on vscode terminal on Windows

  • Expected output:

How has this been tested?

Manual testing on Windows as above.

Test Configuration:

  • ESP-IDF Version: 5.3.2
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v2.0.0 milestone Dec 23, 2024
@brianignacio5 brianignacio5 self-assigned this Dec 23, 2024
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 modified the milestones: v2.0.0, v1.9.1 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.9 new esp-idf terminal can't support bat build (VSC-1542)
1 participant