Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove efuse validation for JTAG #1382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

radurentea
Copy link
Collaborator

Description

Removing extra validation that was added with the enhancement of flash encryption in 1.9.0 release. The validation was checking efuse to see if JTAG is disabled on the board, by doing this the board was being reset to enter second bootloader. This was causing a timing issue with JTAG flashing.
These types of low level validation needs to be handled by OPENOCD.

Fixes #1368

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Flash a project using JTAG flash method.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.3.2
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTAG flashing error on 1.9.0 (VSC-1540)
2 participants