Electrokinetics tutorial #4782
Merged
Electrokinetics tutorial #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
christophlohrmann
suggested changes
Sep 6, 2023
| " ext_efield=[0., 0., 0.], tau=TAU)\n", | ||
| "system.ekcontainer.add(species)\n", | ||
| "\n", | ||
| "species[BOX_L[0] // 2, BOX_L[1] // 2, 0].density = 1.0" |
There was a problem hiding this comment.
I would put 1/agrid**3 here to make sure there is one unit of material in the system.
Alternatively would using a gaussian as the starting condition reduce numerical errors connected to discretised gradients?
christophlohrmann
approved these changes
Sep 27, 2023
jngrad
force-pushed
the
tutorial_electrokinetics
branch
from
497b651 to
b7617a3
Compare
Write tests to check for analytical solutions and turbulent flow. Improve matplotlib figures, ffmpeg videos and png figure captions. Fix undefined behavior during integration (missing LB thermostat).
jngrad
force-pushed
the
tutorial_electrokinetics
branch
from
b7617a3 to
d330457
Compare
jngrad
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write diffusion-advection-reaction tutorial.