Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZnDraw visualizer #4976

Merged
merged 1 commit into from
Aug 30, 2024
Merged

ZnDraw visualizer #4976

merged 1 commit into from
Aug 30, 2024

Conversation

Frieda95
Copy link
Contributor

@Frieda95 Frieda95 commented Aug 12, 2024

Fixes #4961

Description of changes:

  • ZnDraw incorporated in charged system, polymers, and Lennard-Jones tutorials

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jngrad jngrad marked this pull request as draft August 12, 2024 14:56
@jngrad jngrad changed the title Zndraw visualizer (Draft) ZnDraw visualizer Aug 12, 2024
@jngrad
Copy link
Member

jngrad commented Aug 23, 2024

@Frieda95 The requested ZnDraw features are now available on the main branch. You can avoid the merge conflicts and continue your work by running these commands:

git fetch upstream python
git branch -m zndraw_visualizer zndraw_visualizer_old # rename branch
git checkout -b zndraw_visualizer upstream/python # create fresh branch from main
git cherry-pick 35e061759 # carry over only the tutorial changes

@Frieda95 Frieda95 marked this pull request as ready for review August 30, 2024 14:19
@Frieda95
Copy link
Contributor Author

ZnDraw at present doesn't allow multiple servers. So its not incorporated in the Lattice Boltzmann tutorial, which requires simultaneous visualization of Langevin dynamics and hydrodynamic systems.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 1e3d4fb into espressomd:python Aug 30, 2024
10 checks passed
@jngrad jngrad added this to the ESPResSo 4.3.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZnDraw-based visualization to tutorials
2 participants