-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an event on_lees_edwards_change #4977
Conversation
LGTM. Could you please check the codecov tst for the patch (which shows that coverage deceased slightly) and make sure, we don't have important code untested? |
As far as I can tell, it is only complaining about the function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! I have selected a few lines were we potentially have edge cases that may need extra attention.
I noticed a lot of commits don't pass CI. Would you kindly update your virtual environment using our pep8 instructions? |
ed29e9a
to
8434cb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Fixes #4874
Description of changes: