Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpointing bug and improve CI stability #4986

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Aug 23, 2024

Fixes #4964

Description of changes:

  • bugfix: checkpointing can be used more than once again
    • the regression was introduced by the ASE bindings
    • the checkpointing tests now save the checkpoint a second time
  • add missing include guards in the testsuite
  • fix Doxygen CI job

jngrad added 3 commits August 22, 2024 20:32
Use standard CMake functionality instead of GNU sed extensions.
Fix Doxygen warnings about undocumented parameters.
Clang with UBSAN takes 3 to 10 min to compile each Ekin kernel. GCC
builds with maxset can last for more than 1 hour due to wait times
when downloading Docker images, assembling the code coverage report,
or uploading the job artifacts.
@jngrad jngrad marked this pull request as draft August 23, 2024 06:24
@jngrad jngrad force-pushed the devops branch 2 times, most recently from 0d0b0bc to a736802 Compare August 23, 2024 06:53
@jngrad jngrad marked this pull request as ready for review August 23, 2024 08:52
@jngrad jngrad added the automerge Merge with kodiak label Aug 23, 2024
@kodiakhq kodiakhq bot merged commit e3ac3af into espressomd:python Aug 23, 2024
10 checks passed
@jngrad jngrad deleted the devops branch August 23, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with specific myconfig.hpp
2 participants