Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code portability #5020

Open
wants to merge 5 commits into
base: python
Choose a base branch
from
Open

Improve code portability #5020

wants to merge 5 commits into from

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Dec 17, 2024 •
edited
Loading

Description of changes:

  • upgrade to latest waLBerla version and most recent pystencils/lbmpy/sympy releases
    • rewrite codegen pipeline to support multiple pystencils versions
  • bugfixes:
    • remove sources of NaN, float overflow, and most float underflow
    • copy all waLBerla shared objects to the installation directory
    • add prefix to waLBerla and Caliper shared objects to avoid name clashes
  • new feature: floating point exceptions instrumentation for x86 and Armv8
  • run CI on Apple M1 (virtual machine, ARM 64bit architecture)
  • give fine control over Clang-Tidy diagnostics for each CMake target

@jngrad
Remove sources of undefined behavior
81e05cc 
Avoid generating NaN values. Avoid calling virtual functions during
construction or destruction. Address various Clang-Tidy diagnostics.
Remove standard library features deprecated in C++26. Adjust test
tolerances for ARM 64bit architectures. Reduce sources of underflow.
@jngrad
Modernize codegen pipeline
92988b2
@jngrad
Bump version requirements
e21f3b7 
Bump waLBerla, codegen, Caliper dependencies to the latest releases.
Add partial support for pystencils 2.0. Regenerate waLBerla kernels.
Migrate GitHub Actions to fast, ARM-compatible macOS runners.
@jngrad
Custom Clang-Tidy diagnostics for each CMake target
f87aa66
@jngrad
Floating-point exceptions instrumentation
36d3537
@jngrad jngrad marked this pull request as ready for review December 18, 2024 01:05
@jngrad jngrad added this to the ESPResSo 4.3.0 milestone Dec 18, 2024
@jngrad jngrad requested a review from reinaual December 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual Awaiting requested review from reinaual

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BugFix CMake CodeQuality dependencies Pull requests that update a dependency file DevOps Improvement New Feature
Projects
None yet
Milestone
ESPResSo 4.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jngrad