dtlaunch: remember page between dtlaunch instances #3642
Conversation
|
hm, the linter doesn't seem to handle |
apps/dtlaunch/app-b2.js
Outdated
| @@ -33,7 +33,8 @@ | |||
| s.writeJSON("launch.cache.json", launchCache); | |||
| } | |||
| let apps = launchCache.apps; | |||
| for (let i = 0; i < 4; i++) { // Initially only load icons for the current page. | |||
| let page = (Bangle.dtHandlePagePersist&&Bangle.dtHandlePagePersist()) ?? (parseInt(s.read("dtlaunch.page")) ?? 0); | |||
There was a problem hiding this comment.
The bot complains about ?? here.
There was a problem hiding this comment.
Yes, I think the linter doesn't know how to handle ??, I'm sure @gfwilliams pointed out why/what changes would need to be made previously but I can't find the comment
There was a problem hiding this comment.
It'll be the acorn parse in sanitycheck - it would be a nice one to fix I guess
|
It feels like this adds just enough milliseconds to be noticable when switching back and forth to the clock. Feels a little less snappy. Might do some timings to compare. |
apps/dtlaunch/app-b2.js
Outdated
|
|
||
| this.page = page; | ||
| }; | ||
| Bangle.dtHandlePagePersist(page); |
There was a problem hiding this comment.
Similarly to the this thing above, do we want to chuck this onto Bangle, or perhaps we just have an unrelated global object we use instead?
There was a problem hiding this comment.
Maybe that's better!
Should I do it by e.g. global.dtlaunch = {}; global.dtlaunch.handlePagePersist = ()=>{...}?
There was a problem hiding this comment.
Nice, yeah I think that'll work great - and if you make it
global.dtlaunch.handlePagePersist = function() {...}
// ^~~~~~~~then when you call it as dtlaunch.handlePagePersist(), then you can use this exactly as you intended (as this == dtlaunch)
There was a problem hiding this comment.
Nice - perhaps we want to camelCase the function to keep with the existing pattern? (handlePagePersist instead of HandlePagePersist)
There was a problem hiding this comment.
Yes - just noticed that as well 👍
There was a problem hiding this comment.
Nice, yeah I think that'll work great - and if you make it
global.dtlaunch.handlePagePersist = function() {...} // ^~~~~~~~then when you call it as
dtlaunch.handlePagePersist(), then you can usethisexactly as you intended (asthis == dtlaunch)
Interesting! So that's a difference between function() {...} and () => {...} ?
There was a problem hiding this comment.
... also is the global at the beginning in your suggestion required as well?
There was a problem hiding this comment.
Yes exactly - () => ... won't have its own this, it just uses one from up a level, whereas functions always have their own this. Also no, the global at the start of my suggestion isn't needed, nice spot
What you have now looks great btw!
The global dtlaunch object contains function and information to restore the page between instances of dtlaunch.
|
Measuring performance on non-pretokenized code: Time to first draw: 438 ms -> 441 ms (shouldn't be noticable, I guess I placeboed myself) Time until the whole file has run: 600 ms -> 615 ms |
@bobrippling interested what you think about this!
Available on https://thyttan.github.io/BangleApps/?id=dtlaunch