Add missing locale conversions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry this might be more complicated than I first thought. I think something else is breaking the locales, these characters seem to only be present in the CLDR data. Either way if you don't mind adding them, it would make my life a bit easier :) |
|
Thanks! Yes, no problem at all adding these. Anything to map from char code >256 down to ISO8859-1 is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These characters were flagged by the script in espruino/BangleApps#3268 - they are used in some of the locales but are not supported by Banglejs.
Some of them are only used in the CLDR data, but some of them are also used right now in real locales, so those locales are just broken. Even if we never merge the CLDR script, I don't see the harm in adding a few characters to this list.