Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Top Site Detail shows "undefined" after visiting a site for a very short period of time #137

Closed
vezwork opened this issue Apr 9, 2021 · 4 comments · Fixed by #141
Closed

[BUG] Top Site Detail shows "undefined" after visiting a site for a very short period of time #137

vezwork opened this issue Apr 9, 2021 · 4 comments · Fixed by #141
Assignees
@vezwork
Labels
bug Something isn't working priority 1 Highest priority regression Something that used to work isn't working anymore
Milestone
Submit to Firefox...

Comments

@vezwork
Copy link
Member

vezwork commented Apr 9, 2021

Describe the bug
Top site detail incorrectly shows the text "undefined".

To Reproduce
Steps to reproduce the behavior:

  1. Remove Akita if you already have it installed
  2. Install Akita and Coil, pay for Coil (not sure if coil is necessary)
  3. In the Akita browser extension pop-up tutorial click on the "puma browser" link
  4. Observe that the puma web browser website opens
  5. Open the akita browser extension and observe that the puma web browser website does not show in top sites (sleepy akita should be showing).
  6. Navigate to a web monetized site like akitaproject.site
  7. Open the akita browser extension and observe that the puma web browser website and akitaproject.site show up in top sites.
  8. Hover over the puma browser top site circle and see the text "undefined"

Expected behavior
In reproduction step 6 the puma web browser website should have shown in top sites. In step 7 the text should say something like "You've spent _ second of monetized time here ..." but it says "undefined"

Screenshots

Desktop (please complete the following information):

  • OS and Version: macOS 11.2
  • Browser: Chrome
@vezwork vezwork added the bug Something isn't working label Apr 9, 2021
@vezwork
Copy link
Member Author

vezwork commented Apr 9, 2021 •
edited
Loading

Also saw this after visiting https://defold.itch.io/climberz

@sharon-wang
Copy link
Member

sharon-wang commented Apr 9, 2021 •
edited
Loading

I'm also seeing this without a Web Monetization provider installed on Brave.

Confirming this happens with the Puma Browser site, but also https://www.grantfortheweb.org/:

image

@sharon-wang
Copy link
Member

I'm thinking this could be related to #125, since that touches the extension text. We essentially only made frontend changes this milestone, so not sure what else might have caused this regression.

@sharon-wang sharon-wang added the priority 1 Highest priority label Apr 9, 2021
@vezwork
Copy link
Member Author

vezwork commented Apr 9, 2021 •
edited
Loading

Also an issue on edge BUT NOT an issue on Firefox.

@sharon-wang sharon-wang added the regression Something that used to work isn't working anymore label Apr 9, 2021
@vezwork vezwork mentioned this issue Apr 9, 2021
Closed
@vezwork vezwork mentioned this issue Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezwork vezwork

Labels
bug Something isn't working priority 1 Highest priority regression Something that used to work isn't working anymore
Projects
None yet
Milestone
Submit to Firefox/Chrome/Edge
Development

Successfully merging a pull request may close this issue.

Fix favicon loading so it does not block data storage vezwork/akita
2 participants
@vezwork @sharon-wang