Fix favicon loading so it does not block data storage #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
requested changes
Apr 17, 2021
vezwork
force-pushed
the
fixUndefinedTimeSpentDetail
branch
from
a02faa0 to
5276724
Compare
vezwork
force-pushed
the
fixUndefinedTimeSpentDetail
branch
from
5276724 to
3edf9ab
Compare
vezwork
added a commit
to vezwork/akita
that referenced
this pull request
May 28, 2021
This bug was introduced in esse-dev#141. This PR made it so that favicon fetching did not block storing originData. This resulted in the originData object being updated after it had already been stored, meaning the updated originData object was never stored. Fixing this issue requires introducing a new function `storeOriginFavicon`which fetches the favicon, and once/if the fetch resolves, updates and stores the originData safely using a lock.
sharon-wang
added a commit
that referenced
this pull request
May 30, 2021
* Fix originData favicon path not being stored This bug was introduced in #141. This PR made it so that favicon fetching did not block storing originData. This resulted in the originData object being updated after it had already been stored, meaning the updated originData object was never stored. Fixing this issue requires introducing a new function `storeOriginFavicon`which fetches the favicon, and once/if the fetch resolves, updates and stores the originData safely using a lock. * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Update src/data/storage.js Co-authored-by: Sharon Wang <[email protected]> * Address PR comments * Fix nits Co-authored-by: Sharon Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137 [BUG] Top Site Detail shows "undefined" after visiting a site for a very short period of time
Changes
awaitfrom theupdateOriginFaviconfunction call in theupdateAkitaDatafunction definition instorage.js. Thisawaitwas causing an issue because theupdateOriginFaviconfunction awaits a fetch on the favicon image which may take an indefinite time to complete, blocking the function and in-turn indefinitely blocking data storage in theupdateAkitaDatafunction.visitCountortimeSpentare 0.