Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI bugs related to links #117

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Conversation

sharon-wang
Copy link
Member

@sharon-wang sharon-wang commented Jan 30, 2021

Fixes:

  • non-functional links when the user does not have any top sites yet
  • flickering tooltip when hovering on a resource link in the extension tutorial

A new Akita release will be created with these changes. The extension version has been updated to 1.0.1 in the manifest.

@sharon-wang sharon-wang requested a review from vezwork January 30, 2021 23:23
Copy link
Member

@vezwork vezwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge once you've tested please @sharon-wang !

@sharon-wang
Copy link
Member Author

Tested with pre-top sites showing up and post-top sites in the extension. Working! Merging.

@sharon-wang sharon-wang merged commit 4dd85c1 into esse-dev:master Jan 31, 2021
@sharon-wang sharon-wang deleted the fixlinks branch January 31, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants