Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package script to include needed subdirectories in assets #118

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

sharon-wang
Copy link
Member

Assets were getting left out of the package since the script was not updated when the asset directory structure was updated.

This adds only the necessary assets/directories for the extension (leaves out images we use exclusively in our GitHub documentation, for example).

Perhaps in the future there's a better directory structure we can use that simplifies the script.

Copy link
Member

@vezwork vezwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vezwork vezwork merged commit ad51653 into esse-dev:master Feb 1, 2021
@sharon-wang sharon-wang deleted the fixpackagescript branch April 4, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants