Move class fields into constructor to avoid Firefox add-on errors #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
changed the title
sharon-wang
changed the title
sharon-wang
force-pushed
the
fixfirefoxerrors
branch
from
99a6268 to
887289e
Compare
Defining class fields is invalid in older versions of JavaScript, which Firefox seems to test for in its add-on scanning. Moving the fields into the class's constructor avoids these errors. Signed-off-by: sharon-wang <[email protected]>
Signed-off-by: sharon-wang <[email protected]>
sharon-wang
force-pushed
the
fixfirefoxerrors
branch
from
887289e to
2d2ac60
Compare
vezwork
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining class fields is invalid in older versions of JavaScript, which Firefox seems to test for in its add-on scanning. Moving the fields into the class's constructor avoids these errors. This resolves "Errors: Declaring class properties outside of the constructor." of #65.
Some minor refactoring to the constructors and
fromObject()was done for better consistency.Testing: