-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usages of innerHTML with innerText or by appending elements #125
Conversation
I have tested locally without a provider, and it is working as expected✅. |
I have tested locally with Coil, and it is working as expected✅. |
21dda16
to
75ee0d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of nits, otherwise looks good!
Going to test on some browsers now.
src/popup/popup.js
Outdated
// return `<a href="${origin}" style="color: black; text-decoration: underline;">${origin}</a><br><br> | ||
// ${timeSpentString} | ||
// ${visitCountString} | ||
// ${paymentString}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls yeet this
Looks good on Chrome, Brave, Edge. Will test on Firefox after your updates & rebase off master. (testing without WM provider) |
77793a7
to
5e13af6
Compare
Looks good on FF too. Ready for a squash and then merge :) |
Moves getSentAssetsMapAsString to popup.js and make it return els address comments - make use of backticks consistent
5e13af6
to
ba2ec33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was merged without explicit "Approval", but this is approved.
Fixes part 4 (Warnings: Use of .innerHTML with dynamic content.) of #65.
Changes
element.innerHTML
either with:.innerText
(when the element only contains text) orpopup.js
.getSentAssetsMapAsString
togetSentAssetsMapAsEls
and moves it frommain.js
topopup.js
(since it now uses the HTML helper functions).a
andp
elements in top site detail to make up for styling previously added by.innerHTML
.Testing Notes